feat: add filtersBar component - #1158
Merged
Merged
Conversation
| isActive: (name: string) => boolean; | ||
| } | ||
|
|
||
| export const FiltersBarContext = createContext<FiltersBarContextValue | null>(null); |
Contributor
There was a problem hiding this comment.
Why don't you use createSimpleContext from @marble/shared ?
Contributor
Author
There was a problem hiding this comment.
oh I saw import { createSimpleContext } from '@app-builder/utils/create-context' only and wasn't aware we have the same in shared package
Comment on lines
+13
to
+18
| export function useFiltersBarContext(): FiltersBarContextValue { | ||
| const ctx = FiltersBarContext.useValue(); | ||
| if (ctx) return ctx; | ||
|
|
||
| throw new Error('useFiltersBarContext must be used within FiltersBar'); | ||
| } |
Contributor
There was a problem hiding this comment.
useValue already throw when no ctx exist
siiick
force-pushed
the
feat/ds-filtersbar2
branch
from
October 10, 2025 12:31
eef0bd0 to
205b29a
Compare
siiick
force-pushed
the
feat/ds-filtersbar2
branch
from
October 10, 2025 15:25
e6a0d7c to
a2371a9
Compare
siiick
enabled auto-merge (squash)
October 10, 2025 15:25
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New filter bar component.
Support both base and additional filters.
Translations are injected from the client app.
Fully typed filter descriptors and updates events API.
Translations keys are to be defined, we need to discuss on this @ChibiBlasphem